我有兩種方法：public ActionResult<IEnumerable<IDataObject>> GetRelatedObjects([CanBeNull] string className, [CanBeNull] string primaryKey, [CanBeNull] string relationName){ if (string.IsNullOrWhiteSpace(primaryKey)) { return BadRequest("Primary key cannot be empty."); } if (!TryGetClass(className, out var metaClass)) { return NotFound($"Class [{className}] does not exist."); } if (!metaClass.Properties.TryGetValue(relationName, out var property)) { return NotFound($"Class [{metaClass}] does not contain property [{relationName}]."); } if (!(property is IMetaRelation relation)) { return BadRequest($"Property [{relationName}] is not a relation."); } if (relation.Target.Cardinality != MetaCardinality.Multiple) { return BadRequest(`$"Relation [{relationName}] has multiple cardinality."`); } if (!_primaryKeyHandler.TryParsePrimaryKey(metaClass, primaryKey, out var primaryKeyValues)) { return BadRequest("Cannot convert the primaryKey to the correct type."); } if (!_dataCalculator.SupportsData(metaClass)) { return BadRequest($"The class [{className}] is not persisted"); } var metaObject = _dataAccess.GetObject<IDataObject>(DataSession, metaClass, primaryKeyValues); if (metaObject == null) { return NotFound($"The metaObject for the primaryKey [{primaryKey}] nad the class [{className}] cannot be empty."); } // The validations above are the same as for GetRelatedObject() try { var list = _dataAccess.GetRelatedList<IDataObject>(DataSession, metaClass, primaryKeyValues, relation); return new ActionResult<IEnumerable<IDataObject>>(list); } catch (InvalidAuthorizationException) { return Unauthorized(); }}正如代碼中的注釋所標(biāo)記的，兩種方法中的驗(yàn)證是相同的。在這兩種方法中，都有一小部分代碼不相同。兩種方法的返回類型也不同。我正在嘗試將方法內(nèi)的驗(yàn)證重構(gòu)為一個單獨(dú)的方法。
1 回答
慕沐林林
TA貢獻(xiàn)2016條經(jīng)驗(yàn) 獲得超9個贊
您在代碼中聲明了每種方法的驗(yàn)證都是相同的......但事實(shí)并非如此。
從獲取相關(guān)對象：
if (relation.Target.Cardinality == MetaCardinality.Multiple)
{
return BadRequest($"Relation [{relationName}] has multiple cardinality.");
}
從獲取相關(guān)對象：
if (relation.Target.Cardinality != MetaCardinality.Multiple)
{
return BadRequest("The cardinality is not multiple");
}
話雖這么說，我會做這樣的事情，并將驗(yàn)證合并到一個方法中以減少代碼重復(fù)，添加一個參數(shù)以在多個/單個基數(shù)之間切換。
未經(jīng)測試，所以我不知道它是否真的有效；）
public ActionResult<IDataObject> GetRelatedObject([CanBeNull] string className, [CanBeNull] string primaryKey, [CanBeNull] string relationName)
{
var validationError = ValidateRequest(className, primaryKey, relationName, allowMultipleCardinality: false);
if (validationError) return validationError;
try
{
var relationValue = metaObject.GetObject<IDataObject>(relation);
return new ActionResult<IDataObject>(relationValue);
}
catch (InvalidAuthorizationException)
{
return Unauthorized();
}
}
public ActionResult<IEnumerable<IDataObject>> GetRelatedObjects([CanBeNull] string className, [CanBeNull] string primaryKey, [CanBeNull] string relationName)
{
var validationError = ValidateRequest(className, primaryKey, relationName, allowMultipleCardinality: true);
if (validationError) return validationError;
try
{
var list = _dataAccess.GetRelatedList<IDataObject>(DataSession, metaClass, primaryKeyValues, relation);
return new ActionResult<IEnumerable<IDataObject>>(list);
}
catch (InvalidAuthorizationException)
{
return Unauthorized();
}
}
private ActionResult ValidateRequest([CanBeNull] string className, [CanBeNull] string primaryKey, [CanBeNull] string relationName, bool allowMultipleCardinality)
{
if (string.IsNullOrWhiteSpace(primaryKey))
{
return BadRequest("Primary key cannot be empty.");
}
if (!TryGetClass(className, out var metaClass))
{
return NotFound($"Class [{className}] does not exist.");
}
if (!metaClass.Properties.TryGetValue(relationName, out var property))
{
return NotFound($"Class [{metaClass}] does not contain property [{relationName}].");
}
if (!(property is IMetaRelation relation))
{
return BadRequest($"Property [{relationName}] is not a relation.");
}
if (AllowMultipleCardinality)
{
if (relation.Target.Cardinality != MetaCardinality.Multiple)
{
return BadRequest("The cardinality is not multiple");
}
}
else
{
if (relation.Target.Cardinality == MetaCardinality.Multiple)
{
return BadRequest($"Relation [{relationName}] has multiple cardinality.");
}
}
if (!_primaryKeyHandler.TryParsePrimaryKey(metaClass, primaryKey, out var primaryKeyValues))
{
return BadRequest("Cannot convert the primaryKey to the correct type.");
}
if (!_dataCalculator.SupportsData(metaClass))
{
return BadRequest($"The class [{className}] is not persisted");
}
var metaObject = _dataAccess.GetObject<IDataObject>(DataSession, metaClass, primaryKeyValues);
if (metaObject == null)
{
return NotFound($"The metaObject for the primaryKey [{primaryKey}] nad the class [{className}] cannot be empty.");
}
}
- 1 回答
- 0 關(guān)注
- 173 瀏覽
添加回答
舉報
0/150
提交
取消