if($data['params']['by'] == "date" && $data['params']['cnstr_type'] == "1"){ $this->load->view('profile/report_view/page1', $data); } elseif($data['params']['by'] == "date" && $data['params']['cnstr_type'] == "2") { $this->load->view('profile/report_view/page2', $data); } elseif($data['params']['by'] == "week" && $data['params']['cnstr_type'] == "1") { $this->load->view('profile/report_view/page3', $data); } elseif($data['params']['by'] == "week" && $data['params']['cnstr_type'] == "2") { $this->load->view('profile/report_view/page4', $data); }有沒有更好的方法來改進(jìn)這段代碼
2 回答
子衿沉夜
TA貢獻(xiàn)1828條經(jīng)驗(yàn) 獲得超3個(gè)贊
您可以擁有一個(gè)交叉引用組合的數(shù)組，而不是擁有不斷擴(kuò)展的 ifif或語句組合列表。switch然后測(cè)試特定組合是否存在并使用頁面的查找值...
$pages = ["date" => [1 =>'profile/report_view/page1',
2 =>'profile/report_view/page2'],
"week" => [1 =>'profile/report_view/page3',
2 =>'profile/report_view/page4']
];
if ( isset($pages[$data['params']['by']][$data['params']['cnstr_type']])) {
$this->load->view($pages[$data['params']['by']][$data['params']['cnstr_type']], $data);
}
如果唯一的變化是結(jié)尾的編號(hào)，您甚至可以profile/report_view/page在對(duì)$this->load->view().
明月笑刀無情
TA貢獻(xiàn)1828條經(jīng)驗(yàn) 獲得超4個(gè)贊
您可以使用switch case來簡(jiǎn)化您的代碼
switch([$data['params']['by'],$data['params']['cnstr_type']]){
case ["date","1"]:
$this->load->view('profile/report_view/page1', $data);
break;
case ["date","2"]:
$this->load->view('profile/report_view/page2', $data);
break;
case ["week","1"]:
$this->load->view('profile/report_view/page3', $data);
break;
case ["week","2"]:
$this->load->view('profile/report_view/page4', $data);
break;
}
這將使您的代碼看起來更整潔。
- 2 回答
- 0 關(guān)注
- 170 瀏覽
添加回答
舉報(bào)
0/150
提交
取消