首頁(yè) 猿問(wèn) 代碼重復(fù)求改進(jìn)方法

代碼重復(fù)求改進(jìn)方法

JavaScript

郎朗坤 2019-05-25 15:28:02

@OverridepublicOptiongetTrafficChartOption(Stringtype,ReportTypereportType,IntegerdeviceId,Integerdirection){Integerdevice=deviceId+1010000;Listdata=chartDao.getTrafficChartData(reportType,device,direction);Stringtitle=Titlehelper.getChartTitle(reportType);Stringsubtitle=Titlehelper.gettrafficSubText(reportType.getReportTime(),deviceId,direction);Optionoption=newOption();switch(type){case"bar":option=BarOption.BarOptionBuiler(title,subtitle,data);break;case"line":option=LineOption.OptionBuilerhelp(title,subtitle,data);break;case"pie":option=PieOption.PieOptionbuilder(title,subtitle,data);break;}returnoption;}@OverridepublicOptiongetAmmeterChartOption(Stringtype,ReportTypereportType,IntegerdeviceId){Listdata=chartDao.getAmmeterDataChartData(reportType,deviceId);Stringtitle=Titlehelper.getChartTitle(reportType);Stringsubtitle=Titlehelper.gettrafficSubText(reportType.getReportTime(),deviceId,1);Optionoption=newOption();switch(type){case"bar":option=BarOption.BarOptionBuiler(title,subtitle,data);break;case"line":option=LineOption.OptionBuilerhelp(title,subtitle,data);break;case"pie":option=PieOption.PieOptionbuilder(title,subtitle,data);break;}returnoption;}代碼結(jié)構(gòu)非常相似，只是dao層取數(shù)據(jù)不一樣，另外這個(gè)switch有沒(méi)有改進(jìn)空間，我知道使用eumn來(lái)枚舉，沒(méi)寫(xiě)以減少無(wú)關(guān)代碼

查看完整描述

2 回答

一只萌萌小番薯

TA貢獻(xiàn)1795條經(jīng)驗(yàn) 獲得超7個(gè)贊

你的代碼是要?jiǎng)?chuàng)建Option類(lèi)，適合使用工廠方法重構(gòu)。//方法參數(shù)盡量少于3個(gè)，3個(gè)以上時(shí)建議使用組合對(duì)象classOptionParam{privateStringtype;privateReportTypereportType;privateIntegerdiviceId;privateIntegerdirection;//getterandsetter}//Option抽象工廠，每個(gè)具體工廠都必須繼承自抽象工廠publicabstractclassAbstractOptionFactory{@AutowiredChartDaochartDao;//希望具體工廠實(shí)現(xiàn)的方法，交于具體工廠實(shí)現(xiàn)abstractListgetData(OptionParamoptionParam);abstractStringgetSubtitle(OptionParamoptionParam);//公共邏輯代碼，創(chuàng)建對(duì)象調(diào)用該方法publicOptioncreate(OptionParamoptionParam){assertoptionParam!=null;assertoptionParam.getReportType()!=null;Stringtype=optionParam.getType();Listdata=getData(optionParam);Stringtitle=Titlehelper.getChartTitle(optionParam.getReportType());Stringsubtitle=getSubtitle(optionParam);Optionoption=newOption();switch(type){case"bar":option=BarOption.BarOptionBuiler(title,subtitle,data);break;case"line":option=LineOption.OptionBuilerhelp(title,subtitle,data);break;case"pie":option=PieOption.PieOptionbuilder(title,subtitle,data);break;}returnoption;}}@ComponentclassTrafficChartOptionFactoryextendsAbstractOptionFactory{@OverrideListgetData(OptionParamoptionParam){returnchartDao.getTrafficChartData(optionParam.getReportType(),optionParam.getDiviceId(),optionParam.getDirection());}@OverrideStringgetSubtitle(OptionParamoptionParam){returnTitlehelper.gettrafficSubText(optionParam.getReportType().getReportTime(),optionParam.getDiviceId(),optionParam.getDirection());}}@ComponentclassAmmeterChartOptionFactoryextendsAbstractOptionFactory{@OverrideListgetData(OptionParamoptionParam){returnchartDao.getAmmeterDataChartData(optionParam.getReportType(),optionParam.getDiviceId());}@OverrideStringgetSubtitle(OptionParamoptionParam){returnTitlehelper.gettrafficSubText(optionParam.getReportType().getReportTime(),optionParam.getDiviceId(),1);}}使用工廠方法的好處就不多說(shuō)了，具體可以閱讀我的博客

反對(duì) 回復(fù) 2019-05-25

手掌心

TA貢獻(xiàn)1942條經(jīng)驗(yàn) 獲得超3個(gè)贊

Stringtitle=Titlehelper.getChartTitle(reportType);Stringsubtitle=Titlehelper.gettrafficSubText(reportType.getReportTime(),deviceId,1);Optionoption=newOption();switch(type){case"bar":option=BarOption.BarOptionBuiler(title,subtitle,data);break;case"line":option=LineOption.OptionBuilerhelp(title,subtitle,data);break;case"pie":option=PieOption.PieOptionbuilder(title,subtitle,data);break;}returnoption;這幾行提取出來(lái)放在一個(gè)方法里調(diào)用不就行了